Skip to content

security-review skill tends to put exact secret values to the report #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ei-grad wants to merge 6 commits into
base: main
Choose a base branch
from
Open

security-review skill tends to put exact secret values to the report #91

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ef3a6e
security-review skill tends to put exact secret values to the report
ei-grad Mar 12, 2026
816c313
Update SKILL.md
ei-grad Mar 12, 2026
ec64af2
Update SKILL.md
ei-grad Mar 12, 2026
3b85ec1
Update SKILL.md
ei-grad Mar 12, 2026
ba40eba
Update SKILL.md
ei-grad Mar 12, 2026
99aa593
Use alternative markdown fences to properly handle inner code block
ei-grad Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions plugins/sentry-skills/skills/security-review/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,15 @@ os.system(f"cmd {user_input}") # Command injection

### Always Flag (Secrets)
```
password = "hardcoded"
password = "<hardcoded-value>"
api_key = "sk-..."
AWS_SECRET_ACCESS_KEY = "..."
private_key = "-----BEGIN"
```

> [!NOTE]
Comment thread
sentry[bot] marked this conversation as resolved.
> But NEVER leak exact hardcoded secret values to the report!

### Check Context First (MUST Investigate Before Flagging)
```
# SSRF - ONLY if URL is from user input, NOT from settings/config
Expand Down Expand Up @@ -242,7 +245,7 @@ random.random() for token # FLAG: Security tokens need secrets module

## Output Format

```markdown
~~~markdown
## Security Review: [File/Component Name]

### Summary
Expand All @@ -268,10 +271,13 @@ random.random() for token # FLAG: Security tokens need secrets module
#### [VERIFY-001] [Potential Issue]
- **Location**: `file.py:456`
- **Question**: [What needs to be verified]
```
~~~

If no vulnerabilities found, state: "No high-confidence vulnerabilities identified."

> [!NOTE]
> Ensure "[Vulnerable code snippet]" doesn't contain exact values of hardcoded secrets. They MUST be masked or redacted in the report.

---

## Reference Files
Expand Down