fix(cli): Report final per-file finding counts#293
Merged
Conversation
Use post-processed findings when building per-file report counts and when printing completed Ink file summaries. This keeps rejected or interrupted verification candidates from appearing after the final skill report says no findings. Co-Authored-By: GPT-5 Codex <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warden now derives per-file finding counts from the final post-processed findings array, so rejected verification candidates no longer survive into completed CLI output. This keeps interrupted or verification-rejected runs from showing a stale per-file finding marker next to a final "No findings" report.
Final Finding Counts
Shared report-file helpers count final findings against primary and additional locations while preserving per-file timing and usage metadata. Both the SDK and CLI report paths now use the same helper.
Ink Completion Output
The Ink runner refreshes completed file state from the final skill report before printing the static summary, preventing raw hunk candidates from leaking after post-processing.
Validated with pnpm lint, pnpm run typecheck, pnpm test, and pnpm build.