Skip to content

fix(cli): Label built-in skill sources#294

Merged
dcramer merged 3 commits intomainfrom
fix/builtin-skill-source-label
May 7, 2026
Merged

fix(cli): Label built-in skill sources#294
dcramer merged 3 commits intomainfrom
fix/builtin-skill-source-label

Conversation

@dcramer
Copy link
Copy Markdown
Member

@dcramer dcramer commented May 6, 2026

Built-in skills now show built-in (@sentry/warden) in the direct-run header instead of leaking the installed package cache path. Local repo skills continue to show repo-relative paths, while external custom skill paths remain absolute.

CLI Source Display

formatSkillSource centralizes header source rendering so built-in package roots are detected across source and dist layouts without changing the runner resource root.

Before:

  Source   /Users/.../node_modules/@sentry/warden/src/builtin-skills/security-review

After:

  Source   built-in (@sentry/warden)

Comment thread src/cli/main.ts Outdated
dcramer and others added 2 commits May 6, 2026 16:42
Show built-in skills as coming from @sentry/warden instead of printing package cache paths in the direct-run header.

Keep repo-local skill paths relative and preserve absolute paths for external custom skills.

Co-Authored-By: GPT-5 Codex <noreply@anthropic.com>
Remove the CLI-local duplicate path normalizer and use the shared utility for built-in skill source detection. This keeps path handling in one place without changing behavior.

Co-Authored-By: GPT-5 <noreply@anthropic.com>
@dcramer dcramer force-pushed the fix/builtin-skill-source-label branch from 9dc1703 to d0fe656 Compare May 6, 2026 23:43
@dcramer dcramer marked this pull request as ready for review May 6, 2026 23:47
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d0fe656. Configure here.

Comment thread src/cli/main.ts Outdated
Use the shared repo-relative path utility when formatting skill source paths. Add coverage for repo-root skill sources so the CLI never renders an empty source value.

Co-Authored-By: GPT-5 <noreply@anthropic.com>
@dcramer dcramer merged commit 2480bd6 into main May 7, 2026
14 checks passed
@dcramer dcramer deleted the fix/builtin-skill-source-label branch May 7, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant