-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: implement F16 support in shaders #5701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've marked this as ready for review, as the wgpu specific logic is implemented and would be great to start iterating on it. 2 main blockers are:
|
Dogfooding works! Fixed a few bugs in 30e12b5. Still waiting on upstream. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
One thing I'm concerned is that the polyfills we have in some of the backends might not support |
This comment was marked as resolved.
This comment was marked as resolved.
9c6a9b3
to
9f33e0e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@raphamorim: Can you please post the Git history for |
@ErichDonGubler I apologize, I haven't updated the fork on GH. Just ran a git push 🙏 Regarding that hash I confess I did the fork and published as a test to if it was something worth to maintain and use for wgpu, but in case we plan to use half fork then I just updated the tree to only contain @FL33TW00D changes (along with Cargo.toml) Also please bump to 2.4.2 https://crates.io/crates/half-2 |
9c06280
to
393b3c5
Compare
All comments should be addressed. |
Btw.: |
Yup! I also updated it to use |
@gfx-rs/wgpu: I will take on Mozilla's audit workload for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1cab115
to
efabbf6
Compare
Teo's out, we've handled his previous feedback, and we can iterate on his feedback in follow-up PRs.
Resolved conflicts with the extraction of the |
Co-authored-by: FL33TW00D <[email protected]> Co-authored-by: ErichDonGubler <[email protected]>
efabbf6
to
04dfdd5
Compare
Wooooooooooooo! |
Connections
enable …;
that reports nice errors #6424.enable
directive #5476.Checklist for merge-ability
hexf_parse f16 support: https://github.com/lifthrasiir/hexf. This one won't be fun. Did some work on it here: lifthrasiir/hexf@master...FL33TW00D:hexf:feature/f16 .Deferred to Implement Parsing of Hexadecimal F16 #7046f16
inside push constants.Additional context
F16 is available in >=SM6.2: https://github.com/microsoft/DirectXShaderCompiler/wiki/16-Bit-Scalar-Types