Skip to content

Conversation

SupaMaggie70Incorporated
Copy link
Collaborator

@SupaMaggie70Incorporated SupaMaggie70Incorporated commented Mar 15, 2025

Connections
#7197

Description
Adds a mesh shading api to wgpu and wgpu-core so that further tests/examples/progress can be made.

This is a rather large PR. If it needs to be split up, I suppose that could be done, but the individual parts all kind of interact. Also doesn't help that I've never tried to split up a branch/PR.

Remaining work is all in limits. There are a lot of limits in https://registry.khronos.org/vulkan/specs/latest/man/html/VkPhysicalDeviceMeshShaderPropertiesEXT.html, many of which will be relevant, though plenty of it for naga. I will only try to use the limits we currently need for validation, rather than try to guess which will be useful.

Testing
This change currently has several tests plus an example.

Squash or Rebase?

Not sure about this honestly, due to inexperience with git.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@SupaMaggie70Incorporated SupaMaggie70Incorporated marked this pull request as ready for review March 16, 2025 04:07
@SupaMaggie70Incorporated SupaMaggie70Incorporated requested a review from a team as a code owner March 16, 2025 04:07
@SupaMaggie70Incorporated
Copy link
Collaborator Author

This PR got stuck a while back because I was too lazy to go through and understand wgpu's limit system. It should be good to go now. Not sure if we should try to squeeze this in before the 26.0 launch.

@SupaMaggie70Incorporated SupaMaggie70Incorporated marked this pull request as ready for review July 6, 2025 02:11
@cwfitzgerald cwfitzgerald self-assigned this Jul 9, 2025
@SupaMaggie70Incorporated
Copy link
Collaborator Author

Question regarding mesh shaders in general: is it crucial that good validation is added immediately with PRs? This PR adds some but I suspect that there would be some validation that might be more of a pain to add, and also require some research to determine good defaults/recommended values.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright have a few comments but the code generally looks reasonable and we should air on the side of merge-and-iterate for something this large, so after these small issues, lets do exactly that!

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@cwfitzgerald cwfitzgerald merged commit 074c0e7 into gfx-rs:trunk Jul 25, 2025
40 checks passed
@SupaMaggie70Incorporated SupaMaggie70Incorporated deleted the mesh-shading/wgpu-api branch July 25, 2025 04:39
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Aug 7, 2025
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants