-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for miri to the codebase #7940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice to have, thank you!
It is too bad to lose the implicit test enumeration, especially because the macro suppresses the dead code warning if you forget to add a test to the list. But I think we can land this change and worry about improvements later.
I played with a macro a bit and came up with this, but it doesn't handle the wasm case (or run_sync
, but that shouldn't be hard).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a commented test in this file, it might be worth putting a reminder by the commented test that it needs to be added to the test list if restored.
Wires in support for miri (and potentially ASAN) in the codebase.
Main transform was manually enumerating tests.