-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Implement shader barycentrics #8320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1dba169 to
c6b729b
Compare
c6b729b to
ce96dbd
Compare
ce96dbd to
b853dc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Some small comments.
|
Unfortunately lavapipe doesn't support barycentrics, weirdly. Getting this when running it locally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice
|
@atlv24 FYI I believe that |
Description
Implements shader barycentrics for vk 1.3+ via VK_KHR_fragment_shader_barycentric BaryCoordKHR, dx12 via SV_Barycentrics, and metal 2.2 via barycentric_coord
Testing
There's a wgpu-gpu test.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.