Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not print stack on abort #1081

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

WilliamTambellini
Copy link
Contributor

Add option/envvar to disable stack printing on abort.
Also link some unittests with Threads to fix a link error on ubuntu/g++11 (undef ref to create_pthread).

Add option/envvar to disable stack printing on abort.
Also link some unittests with Threads to fix link errors on
ubuntu/g++11.
@slaren slaren merged commit 1f17c91 into ggml-org:master Jan 23, 2025
3 checks passed
Copy link

@matiaslin matiaslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Tested locally and we see no stack when aborting if GGML_NO_BACKTRACE is specified.

@WilliamTambellini
Copy link
Contributor Author

tks Diego

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants