Skip to content

update rope_multi: #12665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

update rope_multi: #12665

merged 2 commits into from
Aug 13, 2025

Conversation

foldl
Copy link
Contributor

@foldl foldl commented Mar 31, 2025

  1. add ggml_rope_multi_inplace, the inplace version rope_multi;
  2. use GGML_MROPE_SECTIONS instead of 4.

Make sure to read the contributing guidelines before submitting a PR

@foldl
update rope_multi:
982e811 
1. add `ggml_rope_multi_inplace`;
1. use `GGML_MROPE_SECTIONS` instead of 4.
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Mar 31, 2025
@foldl
Copy link
Contributor Author

foldl commented Aug 13, 2025

@HimariO @ggerganov I found the inplace version is useful. Would you like to have a look on this?

ggerganov
ggerganov approved these changes Aug 13, 2025
View reviewed changes
@ggerganov ggerganov requested a review from slaren August 13, 2025 08:19
@ggerganov ggerganov merged commit c24f4e2 into ggml-org:master Aug 13, 2025
41 of 47 checks passed
@foldl foldl deleted the update_rope_multi branch August 13, 2025 10:56
the-phobos pushed a commit to the-phobos/llama.cpp that referenced this pull request Aug 14, 2025
@foldl @ggerganov @the-phobos
ggml : update ggml_rope_multi (ggml-org#12665)
60d4182 
* update `rope_multi`:

1. add `ggml_rope_multi_inplace`;
1. use `GGML_MROPE_SECTIONS` instead of 4.

* Apply suggestions from code review

Co-authored-by: Georgi Gerganov <[email protected]>

---------

Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

@slaren slaren slaren approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foldl @ggerganov @slaren