Server webui: Upgrade daisyui, tailwindcss. #12735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
reviewed
Apr 3, 2025
examples/server/webui/src/index.scss
Outdated
| @tailwind components; | ||
| @tailwind utilities; | ||
| @plugin 'daisyui' { | ||
| themes: 'light', 'dark', 'cupcake', 'bumblebee', 'emerald', 'corporate', 'synthwave', 'retro', 'cyberpunk', 'valentine', 'halloween', 'garden', 'forest', 'aqua', 'lofi', 'pastel', 'fantasy', 'wireframe', 'black', 'luxury', 'dracula', 'cmyk', 'autumn', 'business', 'acid', 'lemonade', 'night', 'coffee', 'winter', 'dim', 'nord', 'sunset', |
There was a problem hiding this comment.
You can use all themes by: https://daisyui.com/docs/themes/?lang=en#enable-all-themes
| @@ -194,7 +194,12 @@ const StorageUtils = { | |||
| localStorage.setItem('config', JSON.stringify(config)); | |||
| }, | |||
| getTheme(): string { | |||
| return localStorage.getItem('theme') || 'auto'; | |||
| const theme = localStorage.getItem('theme') || 'auto'; | |||
| const activeTheme = (theme === 'auto') ? | |||
There was a problem hiding this comment.
The themes list didn't include auto on the website. Switching to themes: all added auto back, removed this.
github-actions
bot
added
the
devops
ngxson
reviewed
Apr 4, 2025
.github/workflows/server.yml
Outdated
| @@ -111,6 +111,7 @@ jobs: | |||
| cd examples/server/webui | |||
| git status | |||
|
|
|||
| npm install | |||
There was a problem hiding this comment.
Suggested change
| npm install |
There was a problem hiding this comment.
I am able to build and run locally. The server had a compile error where it was looking for objects in the previous version of daisyui. Didn't realize index.html.gz is part of the git repo, reverting and adding the new index.html.gz.
This reverts commit 336c514.
|
Seems like the gzip on windows produces different result than on linux and mac, this will need to be fixed |
ngxson
approved these changes
Apr 4, 2025
timwu
pushed a commit
to timwu/llama.cpp
that referenced
this pull request
May 5, 2025
* Upgrade daisyui, tailwindcss. * Switch to all themes. * Revert a change. * Update formatting. * Install packages before npm build. * Revert "Install packages before npm build." This reverts commit 336c514. * Add index.html.gz * run build --------- Co-authored-by: Xuan Son Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades packages for daisyui and tailwindcss with code fixes as needed.