vulkan: set cmake minimum and project name in vulkan-shaders #12744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forced the CMAKE_CROSSCOMPILING path in ggml-vulkan/CMakeLists.txt and was able to build it with these minor changes. Without them, the errors were:
I did this experiment with cmake 4.0.0. I didn't get these warnings/errors with the normal build, but I guess they're required when vulkan-shaders-gen is treated as an external project?
This also makes me wonder whether we really need a separate path for cross compiles, or if we could force normal builds down the ExternalProject_Add path. But I didn't attempt to do that in this change.