server : (webui) let server send locally-defined default webui settings #14468
+56
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been clashes, such as in #14041, with decisions about default llama.cpp client-side webui settings which are currently hardcoded and not adjustable by the
llama-server
host without modifying source code. Here I add a command-line argument for the default JSON-encoded client-side settings which are served byllama-server
and read by the webui frontend only if no settings have been saved to local storage.Notably this means that I won't have to maintain a fork and recompile the webui frontend code manually to disable particular settings or buggy functionality (such as setting
pasteLongTextToFileLen
to0
, helping #14041/#14251). Not all settings must be provided. For example,defaultSettings.json:
can be passed via
llama-server --default-client-config defaultSettings.json
.Ultimately this gives more control back to the user to customize the server's deployment.
(And please, if there are minor issues, such as if you want to change the name of the command line flag, reviewers feel free to make changes directly.)