Skip to content

opencl : add GELU_ERF #14476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

opencl : add GELU_ERF #14476

wants to merge 1 commit into from
+75 −0

Conversation

CISC
Copy link
Collaborator

@CISC CISC commented Jul 1, 2025 •
edited
Loading

Adds missing GELU_ERF for OpenCL.

cc/ @lhez Can you test please?

@CISC CISC requested a review from max-krasnyansky July 1, 2025 08:48
@CISC CISC mentioned this pull request Jul 1, 2025
Merged
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Jul 1, 2025
@lhez
Copy link
Contributor

lhez commented Jul 1, 2025

@CISC everything looks good, it passes test-backend-ops.

@CISC
Copy link
Collaborator Author

CISC commented Jul 2, 2025

Awesome, thank you for testing!

@CISC CISC added the OpenCL Issues specific to the OpenCL backend label Jul 2, 2025
@CISC
Copy link
Collaborator Author

CISC commented Jul 4, 2025

@ggerganov Just wondering why @lhez is not a collaborator? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esrakorkmz esrakorkmz esrakorkmz approved these changes

@max-krasnyansky max-krasnyansky Awaiting requested review from max-krasnyansky

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning OpenCL Issues specific to the OpenCL backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CISC @lhez @esrakorkmz