Introduction of CUDA Programmatic Dependent Launch to Llama.cpp #15480
+668
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yeahdongcn
reviewed
Aug 22, 2025
| @@ -3,6 +3,9 @@ | |||
| static __global__ void acc_f32(const float * x, const float * y, float * dst, const int64_t ne, | |||
| const int64_t ne10, const int64_t ne11, const int64_t ne12, const int64_t ne13, | |||
| const int64_t s11, const int64_t s12, const int64_t s13, const int64_t offset) { | |||
| #if !defined(GGML_USE_HIP) && __CUDA_ARCH__ >= GGML_CUDA_CC_HOPPER | |||
There was a problem hiding this comment.
It might be better to define a dedicated macro and use it wherever needed. For example:
#if !defined(GGML_USE_HIP) && __CUDA_ARCH__ >= GGML_CUDA_CC_HOPPER
#define XXX_AVAILABLE
#endif // !defined(GGML_USE_HIP) && __CUDA_ARCH__ >= GGML_CUDA_CC_HOPPER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15479
Make sure to read the contributing guidelines before submitting a PR