Check if ctx or model is null before calling sampler#19101
Open
gagankonana wants to merge 2 commits intoggml-org:masterfrom
Open
Check if ctx or model is null before calling sampler#19101gagankonana wants to merge 2 commits intoggml-org:masterfrom
gagankonana wants to merge 2 commits intoggml-org:masterfrom
Conversation
danbev
approved these changes
Jan 26, 2026
Member
|
This seems to hide some other problem - it's not a valid solution |
Member
Ah yes, it looks like this is because the model is failing to load but we are calling llama_init->sampler(0) without checking the context here: llama.cpp/tools/completion/completion.cpp Lines 144 to 146 in 56f3ebf We should move check of the ctx before this call. |
Author
|
Updated the PR. I followed the pattern from other files. Let me know wdyt |
Member
Thanks! This looks good to me. Can you also take a look at the EditorConfig Checker CI failure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check in main in completion.cpp to check if ctx or model is null before calling sampler. This validates that common_init_from_params was successful
Resolves #19065