Skip to content

common : add specific warning for multiple -m options #19113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danbev wants to merge 2 commits into
base: master
Choose a base branch
from
+29 −8
Open

common : add specific warning for multiple -m options #19113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b96d588
common : add specific warning for multiple -m options
danbev Jan 26, 2026
45d3636
common : through an error for unsupported multiple options
danbev Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions common/arg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,26 @@ static bool parse_bool_value(const std::string & value) {
// CLI argument parsing functions
//

static void check_duplicate_arg(const std::string & arg) {
static const std::set<std::string> multi_value_options = {
"--lora",
"--lora-scaled",
"--control-vector",
"--control-vector-scaled",
"-f", "--file",
"--context-file",
"--api-key",
"--logit-bias",
"--tensor-filter"
};

if (multi_value_options.find(arg) != multi_value_options.end()) {
LOG_INF("DEPRECATED: argument '%s' specified multiple times, use comma-separated values instead (only last value will be used)\n", arg.c_str());
} else {
throw std::invalid_argument(string_format("error: argument '%s' cannot be specified multiple times", arg.c_str()));
}
}

static bool common_params_parse_ex(int argc, char ** argv, common_params_context & ctx_arg) {
common_params & params = ctx_arg.params;

Expand Down Expand Up @@ -476,7 +496,7 @@ static bool common_params_parse_ex(int argc, char ** argv, common_params_context
};

auto parse_cli_args = [&]() {
std::set<std::string> seen_args;
std::set<common_arg *> seen_options;

for (int i = 1; i < argc; i++) {
const std::string arg_prefix = "--";
Expand All @@ -488,12 +508,12 @@ static bool common_params_parse_ex(int argc, char ** argv, common_params_context
if (arg_to_options.find(arg) == arg_to_options.end()) {
throw std::invalid_argument(string_format("error: invalid argument: %s", arg.c_str()));
}
if (!seen_args.insert(arg).second) {
LOG_WRN("DEPRECATED: argument '%s' specified multiple times, use comma-separated values instead (only last value will be used)\n", arg.c_str());
}
auto & tmp = arg_to_options[arg];
auto opt = *tmp.first;
bool is_positive = tmp.second;
if (!seen_options.insert(tmp.first).second) {
check_duplicate_arg(arg);
}
if (opt.has_value_from_env()) {
fprintf(stderr, "warn: %s environment variable is set, but will be overwritten by command line argument %s\n", opt.env, arg.c_str());
}
Expand Down Expand Up @@ -835,7 +855,7 @@ bool common_params_to_map(int argc, char ** argv, llama_example ex, std::map<com
}
};

std::set<std::string> seen_args;
std::set<common_arg *> seen_options;

for (int i = 1; i < argc; i++) {
const std::string arg_prefix = "--";
Expand All @@ -847,10 +867,11 @@ bool common_params_to_map(int argc, char ** argv, llama_example ex, std::map<com
if (arg_to_options.find(arg) == arg_to_options.end()) {
throw std::invalid_argument(string_format("error: invalid argument: %s", arg.c_str()));
}
if (!seen_args.insert(arg).second) {
LOG_WRN("DEPRECATED: argument '%s' specified multiple times, use comma-separated values instead (only last value will be used)\n", arg.c_str());
auto opt_ptr = arg_to_options[arg];
if (!seen_options.insert(opt_ptr).second) {
check_duplicate_arg(arg);
}
auto opt = *arg_to_options[arg];
auto opt = *opt_ptr;
std::string val;
if (opt.value_hint == nullptr && opt.value_hint_2 == nullptr) {
// bool arg (need to reverse the meaning for negative args)
Expand Down
Loading