Skip to content

common: fix 32-bit overflow for avoiding year 2038 problem #19148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GermanAizek wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Open

common: fix 32-bit overflow for avoiding year 2038 problem #19148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions common/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,10 +426,18 @@ std::string string_strip(const std::string & str) {
std::string string_get_sortable_timestamp() {
using clock = std::chrono::system_clock;

const clock::time_point current_time = clock::now();
const time_t as_time_t = clock::to_time_t(current_time);
const auto current_time = clock::now();
const auto as_time_t = std::chrono::duration_cast<std::chrono::seconds>(current_time.time_since_epoch()).count();

struct tm timeinfo;
#ifdef _WIN32
gmtime_s(&timeinfo, &as_time_t);
#else
gmtime_r(&as_time_t, &timeinfo);
#endif

char timestamp_no_ns[100];
std::strftime(timestamp_no_ns, 100, "%Y_%m_%d-%H_%M_%S", std::localtime(&as_time_t));
std::strftime(timestamp_no_ns, 100, "%Y_%m_%d-%H_%M_%S", &timeinfo);

const int64_t ns = std::chrono::duration_cast<std::chrono::nanoseconds>(
current_time.time_since_epoch() % 1000000000).count();
Expand Down
Loading