ggml-backend: fix async set/get fallback sync#19179
Merged
JohannesGaessler merged 1 commit intoggml-org:masterfrom Feb 2, 2026
Merged
ggml-backend: fix async set/get fallback sync#19179JohannesGaessler merged 1 commit intoggml-org:masterfrom
JohannesGaessler merged 1 commit intoggml-org:masterfrom
Conversation
github-actions
bot
added
the
ggml
slaren
approved these changes
Jan 29, 2026
Member
slaren
left a comment
slaren
left a comment
There was a problem hiding this comment.
This change looks good to me. The copy should happen after all previously queued operations, so a synchronization is necessary if the backend does not implement async get/set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on an implementation for backend-agnostic tensor parallelism I found what I believe to be a bug in the ggml backend code. For a minimal implementation I did at first not implement
set_tensor_asyncandget_tensor_asyncassuming that I could just rely on the synchronous fallback and implement those later. However,set_tensor_asyncandget_tensor_asyncdo not callggml_backend_synchronizefor their fallback so I got incorrect results. This PR adds the corresponding calls.