Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ggally_cor): remove unsupported use argument #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinouselouane
Copy link

The ggally_cor function previously included a use argument, documented as
being passed to stats::cor(). However, the function internally calls
stats::cor.test(), which does not accept a use parameter.

As a result, passing use = "complete.obs" or use = "pairwise.complete.obs"
had no effect on the calculation, potentially misleading users who expected
the missing data handling behavior of cor().

This commit:

  • Removes the use argument from the function signature and its documentation.
  • Updates the function to always handle missing values using the default
    behavior of cor.test(), which excludes incomplete observations pairwise.
  • Adds a @details section in the documentation to clarify how missing values
    are treated.

This change brings the implementation in line with the actual behavior and
avoids confusion about NA handling in ggally_cor().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant