fix(ggally_cor): remove unsupported use
argument
#516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ggally_cor
function previously included ause
argument, documented asbeing passed to
stats::cor()
. However, the function internally callsstats::cor.test()
, which does not accept ause
parameter.As a result, passing
use = "complete.obs"
oruse = "pairwise.complete.obs"
had no effect on the calculation, potentially misleading users who expected
the missing data handling behavior of
cor()
.This commit:
use
argument from the function signature and its documentation.behavior of
cor.test()
, which excludes incomplete observations pairwise.@details
section in the documentation to clarify how missing valuesare treated.
This change brings the implementation in line with the actual behavior and
avoids confusion about NA handling in
ggally_cor()
.