Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the Porting Embed Form into a Wizard #4

Merged

Conversation

timomeh
Copy link
Member

@timomeh timomeh commented Feb 26, 2024

  • Check what's the next step in porting
  • Split the porting form up into 4 parts: carrier details, holder details, address, donor approval
  • Adds validation
  • Adds reusable input components to add customization to in the next step

@timomeh timomeh marked this pull request as ready for review March 1, 2024 09:26
@timomeh
Copy link
Member Author

timomeh commented Mar 1, 2024

GitHub Action is borked and won't run, the PR is queued for eternity. I ran everything locally and it passes, so I'm merging this without green CI.

gigs-embeds-js on  timo/conn-680-split-the-porting-form-into-a-multi-step-wizard via  v20.11.0 took 4s 
△ CI=true npm test

> [email protected] test
> vitest


 RUN  v1.2.2 /Users/timomeh/Developer/gigs/gigs-embeds-js

 ✓ lib/PortingEmbed/__tests__/wizardStep.test.ts  (18 tests) 5ms
 ✓ lib/WelcomeEmbed/__tests__/index.test.tsx  (8 tests) 23ms
 ✓ lib/core/__tests__/token.test.ts  (7 tests) 24ms
 ✓ lib/PortingEmbed/__tests__/StepDonorProviderApprovalForm.test.tsx  (6 tests) 100ms
 ✓ lib/core/__tests__/assert.test.ts  (2 tests) 4ms
 ✓ lib/WelcomeEmbed/__tests__/WelcomeEmbed.test.tsx  (4 tests) 19ms
 ✓ lib/WelcomeEmbed/__tests__/TestComponentWithFetch.test.tsx  (2 tests) 28ms
 ✓ lib/PortingEmbed/__tests__/PortingForm.test.tsx  (7 tests) 283ms
 ✓ lib/PortingEmbed/__tests__/StepCarrierDetailsForm.test.tsx  (16 tests) 296ms
 ✓ lib/PortingEmbed/__tests__/StepHolderDetailsForm.test.tsx  (23 tests) 506ms
 ✓ lib/PortingEmbed/__tests__/index.test.tsx  (22 tests) 543ms
 ✓ lib/PortingEmbed/__tests__/StepAddressForm.test.tsx  (32 tests) 653ms
 ✓ lib/PortingEmbed/__tests__/sanitizeSubmitData.test.ts  (4 tests) 3ms
 ✓ lib/core/__tests__/porting.test.ts  (2 tests) 22ms
 ✓ lib/core/__tests__/subscription.test.ts  (2 tests) 18ms
 ✓ lib/PortingEmbed/__tests__/PortingEmbed.test.tsx  (1 test) 15ms

 Test Files  16 passed (16)
      Tests  156 passed (156)
   Start at  10:35:00
   Duration  2.28s (transform 2.38s, setup 3.09s, collect 5.46s, tests 2.54s, environment 3.95s, prepare 1.39s)


gigs-embeds-js on  timo/conn-680-split-the-porting-form-into-a-multi-step-wizard via  v20.11.0 took 3s 
△ CI=true npm run lint

> [email protected] lint
> eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0


gigs-embeds-js on  timo/conn-680-split-the-porting-form-into-a-multi-step-wizard via  v20.11.0 
△ CI=true npm run typecheck

> [email protected] typecheck
> tsc --noEmit


gigs-embeds-js on  timo/conn-680-split-the-porting-form-into-a-multi-step-wizard via  v20.11.0 
△ CI=true npm run build    

> [email protected] build
> tsc && vite build

vite v5.0.12 building for production...
transforming...
✓ 27 modules transformed.
rendering chunks...

[vite:dts] Start generate declaration files...
computing gzip size...
dist/gigs-embeds.js  59.58 kB │ gzip: 16.34 kB
[vite:dts] Start rollup declaration files...
Analysis will use the bundled TypeScript version 5.3.3
[vite:dts] Declaration files built in 1913ms.

dist/gigs-embeds.umd.cjs  41.85 kB │ gzip: 14.21 kB
✓ built in 2.24s

@timomeh timomeh merged commit 96befd7 into main Mar 1, 2024
@timomeh timomeh deleted the timo/conn-680-split-the-porting-form-into-a-multi-step-wizard branch March 1, 2024 09:36
@gigs gigs deleted a comment from linear bot Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant