Skip to content

feat: sharded notes refs for reduced push contention #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
svarlamov wants to merge 9 commits into
base: fix/notes-merge-fallback-and-retry
Choose a base branch
from
Draft

feat: sharded notes refs for reduced push contention #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
155a498
feat: sharded notes refs for reduced push contention on busy monorepos
svarlamov Mar 27, 2026
5cfa8b4
perf: optimize shard merge to minimize git process invocations
svarlamov Mar 27, 2026
7d758f0
fix: defensive guard in shard_for_commit for short SHA strings
svarlamov Mar 27, 2026
f46d91b
fix: collapse nested if to satisfy clippy collapsible_if
svarlamov Mar 27, 2026
9806d37
fix: separate legacy and shard fetch calls to prevent mutual blocking
svarlamov Mar 27, 2026
51cc21f
fix: refresh sharded notes flag in daemon mode
svarlamov Mar 27, 2026
77c5190
test: cover sharded notes default-off gating
svarlamov Mar 27, 2026
3d50a91
test: satisfy clippy for sharded notes coverage
svarlamov Mar 27, 2026
9faf183
ci: retrigger CI after rebase onto updated base branch
svarlamov Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/feature_flags.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ define_feature_flags!(
async_mode: async_mode, debug = false, release = false,
git_hooks_enabled: git_hooks_enabled, debug = false, release = false,
git_hooks_externally_managed: git_hooks_externally_managed, debug = false, release = false,
sharded_notes: sharded_notes, debug = false, release = false, // gated behind config
);

impl FeatureFlags {
Expand Down Expand Up @@ -127,6 +128,7 @@ mod tests {
assert!(!flags.async_mode);
assert!(!flags.git_hooks_enabled);
assert!(!flags.git_hooks_externally_managed);
assert!(!flags.sharded_notes);
}
#[cfg(not(debug_assertions))]
{
Expand All @@ -136,6 +138,7 @@ mod tests {
assert!(!flags.async_mode);
assert!(!flags.git_hooks_enabled);
assert!(!flags.git_hooks_externally_managed);
assert!(!flags.sharded_notes);
}
}

Expand Down Expand Up @@ -245,6 +248,7 @@ mod tests {
async_mode: true,
git_hooks_enabled: false,
git_hooks_externally_managed: false,
sharded_notes: false,
};

let serialized = serde_json::to_string(&flags).unwrap();
Expand All @@ -254,6 +258,7 @@ mod tests {
assert!(serialized.contains("async_mode"));
assert!(serialized.contains("git_hooks_enabled"));
assert!(serialized.contains("git_hooks_externally_managed"));
assert!(serialized.contains("sharded_notes"));
}

#[test]
Expand All @@ -265,6 +270,7 @@ mod tests {
async_mode: true,
git_hooks_enabled: true,
git_hooks_externally_managed: false,
sharded_notes: true,
};
let cloned = flags.clone();
assert_eq!(cloned.rewrite_stash, flags.rewrite_stash);
Expand All @@ -276,6 +282,7 @@ mod tests {
cloned.git_hooks_externally_managed,
flags.git_hooks_externally_managed
);
assert_eq!(cloned.sharded_notes, flags.sharded_notes);
}

#[test]
Expand Down
Loading
Loading