Skip to content

feat: enable async_mode feature flag for new installations#821

Merged
svarlamov merged 1 commit intomainfrom
feat/async-mode-default
Mar 27, 2026
Merged

feat: enable async_mode feature flag for new installations#821
svarlamov merged 1 commit intomainfrom
feat/async-mode-default

Conversation

@svarlamov
Copy link
Member

@svarlamov svarlamov commented Mar 27, 2026

Summary

  • Enables async_mode feature flag by default for new installations only
  • Embeds feature_flags.async_mode: true directly in the initial config.json written by both install.sh and install.ps1
  • Existing users are unaffected — config is only written when config.json does not already exist
  • Added -Depth 3 to ConvertTo-Json in install.ps1 to correctly serialize the nested feature_flags object

Test plan

  • Verify Ubuntu CI tests pass (install-scripts-local workflow)
  • Verify macOS CI tests pass
  • Verify Windows CI tests pass
  • Fresh install creates config.json with feature_flags.async_mode: true
  • Re-running installer on existing install preserves existing config (no overwrite)

🤖 Generated with Claude Code


Open with Devin

Include async_mode in the default config.json written during fresh
installs. Existing users are unaffected since config.json is only
created when it does not already exist.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@svarlamov
Copy link
Member Author

Validated this on real Windows (Microsoft Windows Server 2025 Datacenter 10.0.26100) using the PR's \install.ps1\ from commit \117e972\ with an isolated temp home and a local \git-ai.exe\.

Fresh install: \.git-ai/config.json\ was created with the expected nested config and \ eature_flags.async_mode = true\.

Existing config: pre-seeded \.git-ai/config.json\ was left unchanged on rerun.

Looks good from the Windows installer side.

@svarlamov svarlamov merged commit 6c1fc17 into main Mar 27, 2026
20 of 21 checks passed
@svarlamov svarlamov deleted the feat/async-mode-default branch March 27, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant