Add typed feature flag options to NixOS module#843
Merged
Conversation
Replace the freeform featureFlags attrset (jsonFormat.type) with individually typed boolean options for each known feature flag from feature_flags.rs: asyncMode, rewriteStash, interCommitMove, authKeyring, gitHooksEnabled, and gitHooksExternallyManaged. This allows Nix users to enable async daemon mode via: programs.git-ai.settings.featureFlags.asyncMode = true; rather than needing `git ai config set feature_flags.async_mode true`, which cannot modify config.json when it lives in the Nix store. Typed options take precedence over the extraFlags escape hatch (for forward-compatible unknown flags). Also adds enterprise-latest and enterprise-next to the updateChannel enum. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
featureFlagsJSON attrset with individually typed boolean options for each known feature flag (asyncMode,rewriteStash,interCommitMove,authKeyring,gitHooksEnabled,gitHooksExternallyManaged)extraFlagsescape hatch for forward-compatible unknown flagsenterprise-latestandenterprise-nextvalues toupdateChannelenumMotivation
Nix users cannot run
git ai config set feature_flags.async_mode truebecauseconfig.jsonlives in the Nix store (read-only). Typed options make async daemon mode and other feature flags accessible through the module system:Applied to both the NixOS module and Home Manager module.
Test plan
nix flake check --no-buildpasses"feature_flags": {"async_mode": true}whenasyncMode = truefeature_flagskey in config.jsonextraFlagsvalues are included but overridden by typed options🤖 Generated with Claude Code