Conversation
Both `derive_directory_from_url` and `default_clone_target_from_source` only split on `/` to extract the last path component. On Windows, local paths use `\` as separator, so the entire path (e.g. `C:\Users\...\repo`) was returned as the "directory name" instead of just the basename. This caused post-clone authorship notes fetch to fail for implicit clone targets (no explicit directory argument). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
derive_directory_from_url(cli_parser.rs) anddefault_clone_target_from_source(git_backend.rs) only split on/to extract the clone target basename. On Windows, local paths use\, so the entire path was returned instead of just the directory name, breaking post-clone authorship notes fetch for implicit targets./and\, fixing the 4test_notes_sync_clone_implicit_target_from_non_repo_cwdtest failures on all 3 Windows CI jobs.Test plan
derive_directory_from_urlanddefault_clone_target_from_source🤖 Generated with Claude Code