Skip to content

Commit

Permalink
github-release: remove v2.46.1 work-around
Browse files Browse the repository at this point in the history
The deployment of the v2.46.1 release originally did not work. The
reason was that the GitForWindowsHelper GitHub App lacked the
permissions to create Discussions.

This has been fixed in the meantime, the deployment was completed, and
now we can remove the work-around that allowed us to resume the failed
deployment.

Signed-off-by: Johannes Schindelin <[email protected]>
  • Loading branch information
dscho committed Sep 18, 2024
1 parent b59f512 commit 295d792
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions .github/actions/github-release/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ runs:
text: "For details, see [this run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id}})."
details-url: "https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id}}"
- name: Download bundle-artifacts (needed to push the tag)
# allow resuming failed deployment
if: inputs.tag-name != 'v2.46.1.windows.1'
uses: actions/download-artifact@v4
with:
name: bundle-artifacts
Expand All @@ -91,12 +89,7 @@ runs:
${{ toJSON(inputs.private-key) }},
'${{ inputs.owner }}',
'${{ inputs.repo }}')
await state.refreshToken()
let release
if ('${{ inputs.tag-name }}' === 'v2.46.1.windows.1') {
release = { id: 175612508 }
} else {
const [ artifactsOwner, artifactsRepo ] = '${{ inputs.artifacts-repository }}'.split('/')
const artifacts = await getGitArtifacts(
console,
Expand All @@ -110,7 +103,8 @@ runs:
const sha256sums = sha256sumsFromReleaseNotes(${{ toJSON(inputs.release-notes) }})
await checkSHA256Sums(console, artifacts, sha256sums)
release = await createRelease(
await state.refreshToken()
const release = await createRelease(
console,
state.accessToken,
'${{ inputs.owner }}',
Expand Down Expand Up @@ -156,7 +150,6 @@ runs:
make_latest : !isPrerelease,
}
)
}
try {
await state.refreshToken()
Expand Down

0 comments on commit 295d792

Please sign in to comment.