Hands-on: Fetch and merge from a remote #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woojiahao
requested changes
Nov 10, 2025
Member
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
Left some minor nits about coding convention!
hands_on/fetch_merge.py
Outdated
| from exercise_utils.gitmastery import create_start_tag | ||
|
|
||
| __requires_git__ = True | ||
| __requires_github__ = True |
Member
There was a problem hiding this comment.
If you're not using gh, you don't need this to be set to true
Suggested change
| __requires_github__ = True | |
| __requires_github__ = False |
hands_on/fetch_merge.py
Outdated
|
|
||
| def download(verbose: bool): | ||
| os.makedirs("samplerepo-finances") | ||
| # Clone the samplerepo-finances repo |
Member
There was a problem hiding this comment.
Suggested change
| # Clone the samplerepo-finances repo |
hands_on/fetch_merge.py
Outdated
| # Clone the samplerepo-finances repo | ||
| run_command(["git", "clone", "https://github.com/git-mastery/samplerepo-finances.git"], verbose) | ||
| os.chdir("samplerepo-finances") | ||
| # Change the remote origin to point to samplerepo-finances-2 |
Member
There was a problem hiding this comment.
Suggested change
| # Change the remote origin to point to samplerepo-finances-2 |
hands_on/fetch_merge.py
Outdated
Comment on lines
17
to
18
|
|
||
| pass |
Member
There was a problem hiding this comment.
Suggested change
| pass |
once the function behavior is populated, you are free to remove pass
6 tasks
Author
|
@woojiahao understood, implemented suggested changes in latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise Review
Exercise Discussion
#86
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?