Replace regex with wildmatch, add missing features#1
Merged
Conversation
…itignore API Rewrites the matching engine from regex compilation to a direct wildmatch implementation (two-pointer backtracking, same algorithm as git's wildmatch.c). This fixes bracket expressions, POSIX character classes, and proper ** handling, with 10-20x better match performance. Adds core.excludesfile support, NewFromDirectory and Walk for automatic nested .gitignore discovery, MatchPath, MatchDetail for match provenance, parse error surfacing via Errors(), and literal suffix indexing for fast pattern rejection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the regex matching engine with a direct wildmatch implementation (same algorithm as git's wildmatch.c). Fix trimTrailingSpaces bugs. Add core.excludesfile support, automatic nested .gitignore discovery, match provenance, error reporting, and pattern indexing.