Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use --block option for Kate editor in translations #1966

Closed
wants to merge 1 commit into from

Conversation

DKindeev
Copy link

@DKindeev DKindeev commented Mar 5, 2025

This fixes the kate command, needs to use "kate -b".

@dscho
Copy link
Member

dscho commented Mar 5, 2025

@DKindeev thank you for contributing this fix! I cannot really validate whether it is correct unless I repeat the entire research you have already done, which kind of defeats your research. Maybe it would make more sense to accompany the PR description with a pointer to Kate's documentation?

Additionally, the PR modifies a generated file:

Which means the next time this file is generated, your edit would be gone! So where to contribute the fix instead? The answer lies here:

image

In other words: Please open a new PR at https://github.com/progit2-aze/progit2 and accompany the PR with a description that makes it easy to verify that the change is correct. Thank you!

@DKindeev
Copy link
Author

DKindeev commented Mar 5, 2025

Thank you. I needed to change that in another repo.

@dscho
Copy link
Member

dscho commented Mar 5, 2025

Thank you. I needed to change that in another repo.

I think this is the line you want to change: https://github.com/progit2-aze/progit2/blob/9f5e87d19b622e05fd9f7cc215bcd39c79d5995b/C-git-commands.asc?plain=1#L51

@DKindeev
Copy link
Author

No, I actually wanted to fix russian version of documentation. I have already opened a pr in the correct repo, but it is still hanging. Could you please review it?

progit/progit2-ru#479 - here it is.

@dscho
Copy link
Member

dscho commented Mar 18, 2025

No, I actually wanted to fix russian version of documentation. I have already opened a pr in the correct repo, but it is still hanging. Could you please review it?

progit/progit2-ru#479 - here it is.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants