Changing link color in footer as it fixes #2015 #2017
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To1ne
reviewed
Jul 3, 2025
| @@ -351,7 +351,7 @@ footer { | |||
| color: var(--light-font-color-darker-35); | |||
|
|
|||
| &:hover { | |||
| color: var(--light-font-color-darker-55); | |||
| color: var(--orange); | |||
There was a problem hiding this comment.
To adapt to light and dark better I prefer:
Suggested change
| color: var(--orange); | |
| color: var(--link-color); |
In dark mode it will be the same orange, but in light mode it will be the same blue as other links #0388a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The color of the hyperlinks when hovered is changed to the orange (This orange is not actually orange in light theme as it is defined two color values in the assets/sass/dark-mode.css.
Context
This helps in better visibility as the previous color for the link hovering almost blended with the background
This was discussed with @dscho in issue #2015