Julian/assigmnent details and grouping #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/deploy |
|
Staging deployed on https://git4school-staging.firebaseapp.com/ |
F0urchette
reviewed
Jun 26, 2021
F0urchette
reviewed
Jun 27, 2021
src/app/components/home/assignment-chooser/assignment-chooser.component.ts
Outdated
Show resolved
Hide resolved
F0urchette
reviewed
Jun 27, 2021
src/app/components/home/assignment-chooser/assignment-chooser.component.ts
Outdated
Show resolved
Hide resolved
F0urchette
reviewed
Jun 27, 2021
src/app/components/home/assignment-chooser/assignment-chooser.component.ts
Outdated
Show resolved
Hide resolved
F0urchette
reviewed
Jun 27, 2021
src/app/components/home/assignment-chooser/assignment-chooser.component.ts
Outdated
Show resolved
Hide resolved
F0urchette
reviewed
Jun 27, 2021
src/app/components/home/assignment-chooser/assignment-chooser.component.ts
Outdated
Show resolved
Hide resolved
F0urchette
reviewed
Jun 27, 2021
src/app/components/home/assignment-chooser/assignment-chooser.component.ts
Outdated
Show resolved
Hide resolved
F0urchette
requested changes
Jun 27, 2021
There was a problem hiding this comment.
- The place of the button is not right. It should be moved after the title (on the same line)
Details mode :
- Questions must be displayed in line
Grouping mode :
-
The buttons on the right to manipulate the assignments are missing
-
Only the label is clickable in the group header. The best would be to make the whole line clickable. If this is not possible, the hand cursor should only appear on the label
-
Display "Year not specified" instead of "Year :"
F0urchette
added
the
deploy-staging
|
Staging deployed on https://git4school-staging.firebaseapp.com/ |
github-actions
bot
removed
the
deploy-staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding grouping by year and details function wich display start and end, questions and number of repository.