but push UX updates #10702
Open
but push UX updates #10702
+394
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance push output to display a link to the pushed branch or Gerrit change so users can quickly view their changes on the remote. Added URL generation helpers for GitHub, GitLab and Gerrit (parsing multiple remote URL forms), a wrapper to pick the right URL, and logic to lookup the project's remote URL and print a Branch URL or View changes link after a successful push. Also included a dbg! call for the push result and minor output formatting adjustments.
Show branch and commit web links in the but log output when a remote is available, including Gerrit-aware URLs. This adds URL generation helpers (crates/but/src/url_utils.rs), wires remote/gerrit detection into the log output, and prints per-branch and per-commit URLs (GitHub/GitLab/Gerrit) in the commit graph. It also reuses the new url_utils in push output and cleans up removed duplicate URL helper code from push/mod.rs.
When pushing to Gerrit the post-push dialog sometimes created a review URL but did not display it; additionally push failures printed large, unhelpful error dumps. Add logic to always attempt to display a branch/review URL (when it can be generated) and extract a concise, user-friendly error message from known git/Gerrit error patterns so failures are shown succinctly while still showing the URL when available.
Changes:
- Add show_branch_url() to generate and print a branch or Gerrit "View changes" URL.
- Add extract_push_error_message() to parse common push errors ("no new changes", "remote rejected", "failed to push some refs", permission/network errors) and return a short explanation.
- Replace the previous direct push result handling with match handling: on Ok, print push details and URL; on Err, print the extracted short error message, still show the URL if available, and return the error.
This improves UX by surfacing useful URLs even on failures and by providing readable, actionable error messages instead of large debug dumps.
For Gerrit remotes we now display per-commit Gerrit review URLs (matching how `but status` shows Gerrit URLs) for the commits on the branch that was just pushed. If no individual review URLs are present we fall back to a dashboard/branch URL. For non-Gerrit remotes the existing branch URL logic is preserved. Added helper functions to fetch stack/branch details, format and colorize commit IDs, and improved Gerrit SSH host parsing in URL utilities. Also handle errors when showing URLs without failing the push output.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves
but pushto show urls you can follow up with, also not explode if you try to push to gerrit with no changes.Here is GH:
Here is gerrit now, it will show a url per commit on that branch: