Fix text editor wrapping and improve test reliability #11373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mtsgrd
force-pushed
the
replace-timeouts-with-deterministic-waits
branch
from
8b5ae28 to
dd38d4a
Compare
mtsgrd
force-pushed
the
replace-timeouts-with-deterministic-waits
branch
from
dd38d4a to
19f21ab
Compare
mtsgrd
force-pushed
the
replace-timeouts-with-deterministic-waits
branch
from
19f21ab to
a35ec0c
Compare
mtsgrd
force-pushed
the
replace-timeouts-with-deterministic-waits
branch
from
a35ec0c to
30b3651
Compare
- Replace arbitrary timeouts with deterministic browser idle detection in Playwright tests - Fix line wrapping to use full available width (trim trailing spaces from length calculation) - Simplify rich text editor by removing plaintext mode and markdown transition plugin - Consolidate IndentPlugin to work with paragraph-based structure (remove PlainTextIndentPlugin) - Add comprehensive test utilities for browser idle detection with examples and documentation Fix linewrap tests to expect trimmed newLine values Tests for the rich text editor's linewrap behavior were failing because expectations assumed trailing spaces would be preserved. Update assertions to expect trimmed newLine values (and document that whitespace-only lines become empty) so the tests reflect the actual trimming behavior implemented in the linewrap logic. Preserve single newlines when extracting editor text Fix extra blank lines produced by getTextContent(): instead of using getRoot().getTextContent(), iterate over root children, extract each paragraph's text, and join with single '\n'. This prevents added empty lines between paragraphs and resolves the failing test that was seeing too many newlines.
mtsgrd
force-pushed
the
replace-timeouts-with-deterministic-waits
branch
from
30b3651 to
2ad8c3c
Compare
Contributor
Author
|
@PavelLaptev fyi - if you could keep your eyes out for any regression related to this pr. It's a pretty substantial simplification to the rich text editor in that it removes the |
mtsgrd
commented
Nov 27, 2025
Comment on lines
-358
to
-369
| .editor-scroller { | ||
| display: flex; | ||
| z-index: 0; | ||
| position: relative; | ||
| flex-direction: column; | ||
| height: 100%; | ||
| overflow: auto; | ||
| border: 0; | ||
| outline: 0; | ||
| /* It's unclear why the resizer is on by default on this element. */ | ||
| resize: none; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@PavelLaptev this looks a bit sus, but also it wasn't being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrap Replace setTimeout with deterministic waits in HardWrapPlugin
tests Remove legacy MarkdownTransitionPlugin and simplify initialization