Generalize testsupport mode normalization by filetype

[slarse]

🧢 Changes

Continuation of #11363 with a suggestion to generalize the testsupport file mode normalization.

[vercel]

@slarse is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

[slarse]

From a Git perspective it's a bit weird to propagate permission bits on directories and symlinks, as Git does not store those. But the current snapshots do so.

Do we want to "properly" normalize this to a more Git-aligned view (i.e. zero out the permission bits for these types in existing snapshots), or is this fine?

[slarse]

I realize that if we don't care about "proper" Git normalization for the snapshots, this entire thing could be reduced to just:

    fn normalize_mode(mode: u32) -> u32 {
        let normalize_permission_bits = |mode: u32| if mode & 0o100 == 0 { 0o644 } else { 0o755 };
        (mode & 0o170000) | normalize_permission_bits(mode)
    }

Because every match arm is just doing the same thing right now, except for the panic, which I don't feel strongly about keeping.

[Byron]

Yes, why not go with the minimal version that also can't panic. Let's merge this as well and you can follow it up.

[Byron]

Thanks so much for picking this up!

Despite merging the PR now, I'd also be looking forward to the two-line version that won't panic :).

[Byron]

Yes, why not go with the minimal version that also can't panic. Let's merge this as well and you can follow it up.