Skip to content

Don't rebase for change ids #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Caleb-T-Owens
Copy link
Contributor

@Caleb-T-Owens Caleb-T-Owens commented Apr 25, 2025


⧓ Review in Butler Review #3TnhpHV8L

Don't rebase for change ids

This was relevant when we were using change ids for updating references, but we have since been enlightened and with the glory of the rebase engine, this is no longer needed.

1 commit series (version 1)

Series Commit Title Status Reviewers
1/1 Don't rebase for change ids

Please leave review feedback in the Butler Review

Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 11:09am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 11:09am

@krlvi
Copy link
Member

krlvi commented Apr 25, 2025

@Caleb-T-Owens this may also be relevant for identifying when commits diverge but are the same

@Caleb-T-Owens
Copy link
Contributor Author

@Caleb-T-Owens this may also be relevant for identifying when commits diverge but are the same

That is true. At the same time, Louis tried applying a completely up-to-date depend-a-bot which we then "needlessly" rebased.

This was relevant when we were using change ids for updating references, but we have since been enlightened and with the glory of the rebase engine, this is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants