-
Notifications
You must be signed in to change notification settings - Fork 595
Fix issue with context menu behaviour when extending beyond the boundaries of the window #8279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@imadx is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
Thanks a lot for contributing! I tried it the way I thought it should reproduce, but the issue remained unchanged on MacOS at least. Clicking on the |
@Byron Do you have a screenshot that I can refer to regarding the recreated issue? Here’s what I’m seeing on my local build with the fix on my Mac. |
I think I get it now - the repositioning is working within the frame of the GitButler window. What I tried is to put it against the Screen, assuming it would avoid going off-screen as well. Something that is unrelated, but just so it's documented and with CC to @estib-vega, I saw that the algorithm currently flip-flops if the vertical height isn't sufficient. Screen.Recording.2025-04-29.at.18.48.24.mov |
I've updated the same PR to avoid constant toggling on the context menu as well, in the same PR, since they both relate to the alignment behaviour on context menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
🧢 Changes
☕️ Reasoning
🎫 Affected issues
Fixes: #7912