-
Notifications
You must be signed in to change notification settings - Fork 157
Documentation/git-merge-tree.adoc: clarify the --merge-base option #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Documentation/git-merge-tree.adoc: clarify the --merge-base option #1980
Conversation
The --merge-base option for merge-tree has a few slightly awkward constructions or omissions: * Split the initial long sentence describing the option into two, making the instructions and the limitations clearer for readers. * Add context to the final sentence that might be obvious to some readers but isn't immediately obvious to all. * The discussion about lack of support for multiple merge bases simply leave folks wondering why that matters and could help or hurt. Separate it out and add a brief explanation. Signed-off-by: Elijah Newren <[email protected]>
Ah, the usual Meson failures, and of course without any useful information (which probably was in
Back when the idea was still to use CMake as the next build system, we did not have such unhelpful CI failures. Will re-run, 🤞that it will "magically succeed" now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the original wording is on me. Sorry.
Thanks for digging into this for me.
Thanks, looks like it didn't work but since this is just a documentation change that couldn't cause those build failures, I think I'll just ignore it...
From blame, 2 of the 3 commits that led to the current wording was from Kyle Zhao (and most of the text was from those 2 commits), leaving only 1 to you. Regardless of what blame says, though, I was the reviewer of all three commits on the mailing list, so it's much more on me than on you. |
/submit |
Submitted as [email protected] To fetch this version into
To fetch this version to local tag
|
This patch series was integrated into seen via git@8d41f61. |
This branch is now known as |
This patch series was integrated into seen via git@eed6af7. |
This patch series was integrated into seen via git@cdc1761. |
This patch series was integrated into next via git@787ff6f. |
There was a status update in the "New Topics" section about the branch Clarify the "--merge-base" command line option in "git merge-tree". Will merge to 'master'. source: <[email protected]> |
No description provided.