Skip to content

Conversation

newren
Copy link

@newren newren commented Oct 2, 2025

No description provided.

The --merge-base option for merge-tree has a few slightly awkward
constructions or omissions:
  * Split the initial long sentence describing the option into two,
    making the instructions and the limitations clearer for readers.
  * Add context to the final sentence that might be obvious to some
    readers but isn't immediately obvious to all.
  * The discussion about lack of support for multiple merge bases
    simply leave folks wondering why that matters and could help or
    hurt.  Separate it out and add a brief explanation.

Signed-off-by: Elijah Newren <[email protected]>
@dscho
Copy link
Member

dscho commented Oct 2, 2025

Ah, the usual Meson failures, and of course without any useful information (which probably was in D:\a\git\git\build\meson-logs\testlog.txt and has long ago gone 💥):

------------------------------------- 8< -------------------------------------
stderr:

(test program exited with status code 1)
------------------------------------------------------------------------------


Summary of Failures:

 95/102 t8020-last-modified                            ERROR          16.09s   exit status 1

Ok:                82  
Fail:              1   
Skipped:           19  

Full log written to D:\a\git\git\build\meson-logs\testlog.txt
Error: Process completed with exit code 1.

Back when the idea was still to use CMake as the next build system, we did not have such unhelpful CI failures.

Will re-run, 🤞that it will "magically succeed" now.

Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the original wording is on me. Sorry.

@newren
Copy link
Author

newren commented Oct 2, 2025

Back when the idea was still to use CMake as the next build system, we did not have such unhelpful CI failures.

Thanks for digging into this for me.

Will re-run, 🤞that it will "magically succeed" now.

Thanks, looks like it didn't work but since this is just a documentation change that couldn't cause those build failures, I think I'll just ignore it...

I guess the original wording is on me. Sorry.

From blame, 2 of the 3 commits that led to the current wording was from Kyle Zhao (and most of the text was from those 2 commits), leaving only 1 to you. Regardless of what blame says, though, I was the reviewer of all three commits on the mailing list, so it's much more on me than on you.

@newren
Copy link
Author

newren commented Oct 2, 2025

/submit

Copy link

gitgitgadget bot commented Oct 2, 2025

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1980/newren/merge-tree-merge-base-clarifications-v1

To fetch this version to local tag pr-1980/newren/merge-tree-merge-base-clarifications-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1980/newren/merge-tree-merge-base-clarifications-v1

Copy link

gitgitgadget bot commented Oct 3, 2025

This patch series was integrated into seen via git@8d41f61.

@gitgitgadget gitgitgadget bot added the seen label Oct 3, 2025
Copy link

gitgitgadget bot commented Oct 5, 2025

This branch is now known as en/doc-merge-tree-describe-merge-base.

Copy link

gitgitgadget bot commented Oct 5, 2025

This patch series was integrated into seen via git@eed6af7.

Copy link

gitgitgadget bot commented Oct 6, 2025

This patch series was integrated into seen via git@cdc1761.

Copy link

gitgitgadget bot commented Oct 6, 2025

This patch series was integrated into next via git@787ff6f.

@gitgitgadget gitgitgadget bot added the next label Oct 6, 2025
Copy link

gitgitgadget bot commented Oct 6, 2025

There was a status update in the "New Topics" section about the branch en/doc-merge-tree-describe-merge-base on the Git mailing list:

Clarify the "--merge-base" command line option in "git merge-tree".

Will merge to 'master'.
source: <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants