Release function returns a boolean. Stable version

github-tools · Nov 18, 2015 · d7a8941 · d7a8941
1 parent 4420abc
commit d7a8941
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 14 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "github-release-notes",
-  "version": "0.2.0",
+  "version": "0.2.2",
   "description": "Node module to publish release notes based on commits between the last two tags.",
   "main": "./github-release-notes.js",
   "scripts": {

diff --git a/src/index.js b/src/index.js
@@ -17,16 +17,20 @@ var Github = require('github-api');
  * }
  */
 function makeRelease(gren, releaseOptions) {
-   gren.repo.makeRelease(releaseOptions, function (err, release) {
-      if(err) {
-         var responseText = JSON.parse(err.request.responseText);
-         console.error(
-            responseText.message + '\n'
-            + responseText.errors[0].code
-         );
-      } else {
-         console.info(release.tag_name + ' successfully created!');
-      }
+   return new Promise(function (resolve, reject) {   
+      gren.repo.makeRelease(releaseOptions, function (err, release) {
+         if(err) {
+            var responseText = JSON.parse(err.request.responseText);
+            console.error(
+               responseText.message + '\n'
+               + responseText.errors[0].code
+            );
+            reject(false);
+         } else {
+            console.log(release.tag_name + ' successfully created!');
+            resolve(true);
+         }
+      });
    });
 }
 
@@ -78,7 +82,7 @@ function prepareRelease(gren, tags, commitMessages) {
       prerelease: gren.options.prerelease || false
    };
 
-   makeRelease(gren, releaseOptions);
+   return makeRelease(gren, releaseOptions);
 }
 
 /**
@@ -212,7 +216,7 @@ function GithubReleaseNotes(options) {
 GithubReleaseNotes.prototype.release = function() {
    var that = this;
 
-   getLatestRelease(this)
+   return getLatestRelease(this)
       .then(function (releaseTagName) {
          return getLastTags(that, releaseTagName);
       })
@@ -227,7 +231,10 @@ GithubReleaseNotes.prototype.release = function() {
          return getCommitsBetweenTwo(that, data[1], data[0]);
       })
       .then(function (commitMessages) {
-         prepareRelease(that, tags, commitMessages);
+         return prepareRelease(that, tags, commitMessages);
+      })
+      .then(function (success) {
+         return success;
       })
       .catch(function (error) {
          console.error(error);