Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a rollback mechanism for Java buildless #2129

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

henrymercer
Copy link
Contributor

This PR implements a rollback mechanism for Java buildless. Specifically, when Java is being analyzed and the code_scanning_disable_java_buildless feature flag is enabled, a build-mode: none input will be interpreted as build-mode: autobuild and a warning will be logged.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner February 12, 2024 23:51
@henrymercer henrymercer force-pushed the henrymercer/java-buildless-rollback branch from 57b0651 to 65853b9 Compare February 12, 2024 23:55
angelapwen
angelapwen previously approved these changes Feb 13, 2024
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@henrymercer henrymercer merged commit 95d258a into main Feb 14, 2024
296 checks passed
@henrymercer henrymercer deleted the henrymercer/java-buildless-rollback branch February 14, 2024 16:22
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants