Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generated token on checkout #2481

Merged

Conversation

rvermeulen
Copy link
Contributor

@rvermeulen rvermeulen commented Sep 13, 2024

The script .github/update-release-branch.py uses the git command to push changes. Therefore we need to ensure that git authenticates with a token that has the workflows write permision.

This change restore the GitHub token used by the script to access the API and applies the workflows write permission to the token used by git.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

The script `.github/update-release-branch.py` uses the `git` command
to push changes. Therefore we need to ensure that `git` authenticates
with a token that has the `workflows` write permision.

This change restore the GitHub token used by the script to access the
API and applies the `workflows` write permission to the token used by `git`.
@rvermeulen rvermeulen requested a review from a team as a code owner September 13, 2024 16:16
@dbartol
Copy link
Contributor

dbartol commented Sep 13, 2024

Where does the workflows: write permission get applied?

@rvermeulen
Copy link
Contributor Author

rvermeulen commented Sep 13, 2024

The GitHub App generating the token applies that permission. The token is then used by by git to push.

@dbartol dbartol merged commit 5618c9f into github:main Sep 13, 2024
306 checks passed
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants