Move test utilities to the query pack. #17968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
changed the title
michaelnebel
added
the
no-change-note-required
Contributor
Author
|
DCA looks good. |
michaelnebel
force-pushed
the
java/movetestutils
branch
from
6d8ef2d to
b9625dd
Compare
Contributor
|
Should this be done for Go as well? (Not necessarily in this PR.) |
Contributor
Author
Yes, we should do it for all languages, if we agree that this is an acceptable approach. I intend to do it for all languages in this PR, if there are no objections :-) |
Contributor
Author
|
Putting in draft while making the corresponding changes for the other languages. |
michaelnebel
force-pushed
the
java/movetestutils
branch
from
b9625dd to
da27956
Compare
michaelnebel
changed the title
michaelnebel
force-pushed
the
java/movetestutils
branch
from
f46b0b0 to
0bfc1b6
Compare
Contributor
Author
|
Setting ready for review again.
|
michaelnebel
requested review from
dbartol,
egregius313,
geoffw0 and
hvitved
Contributor
Yes it's an issue that came up yesterday afternoon. I believe it's fixed now on latest |
egregius313
approved these changes
Dec 13, 2024
Contributor
egregius313
left a comment
egregius313
left a comment
There was a problem hiding this comment.
Static languages LGTM
erik-krogh
approved these changes
Dec 16, 2024
hvitved
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the test utilities are moved from the test QL packs into the
codeql/<language>-queriesQL packs.We are in the process of moving the experimental queries from the Code QL repo to the CodeQL-Community-Packs repo, and some of the tests for the experimental queries are relying on the test utilities, which currently aren't being published.
As a temporary workaround a copy of the test utilities are added to the CodeQL-Community-Pack, but we should publish the test utilities to enable sharing.
Moving the test utilities for all languages for consistency.