Brodes/seh flow phase2 splitting seh edges #18049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot apply the edges yet, just stipulates the types.
…rodes/seh_flow_phase2_splitting_seh_edges # Conflicts: # cpp/ql/lib/semmle/code/cpp/ir/implementation/EdgeKind.qll
jketema
reviewed
Dec 5, 2024
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
Mostly comments about the comments again. Just one question about the newly introduced predicate.
Co-authored-by: Jeroen Ketema <[email protected]>
Co-authored-by: Jeroen Ketema <[email protected]>
Co-authored-by: Jeroen Ketema <[email protected]>
Co-authored-by: Jeroen Ketema <[email protected]>
Co-authored-by: Jeroen Ketema <[email protected]>
Co-authored-by: Jeroen Ketema <[email protected]>
…github.com/microsoft/codeql into brodes/seh_flow_phase2_splitting_seh_edges
jketema
reviewed
Dec 5, 2024
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
LGTM. Let me run some DCA on this, once that's done and looks good, I'll merge.
jketema
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2 SEH handling PR. This phase simply establishes there are two edge types. Where a specific edge must be chosen, we assume it is a C++ edge. The next phase PR will fully establish uses of these edge types to correctly distinguish SEH from ordinary C++ exception edges.