C++: Fix a FP in cpp/wrong-number-format-arguments caused by an extraction error

[calumgrant]

Commit-by-commit review encouraged. It's a fairly small fix that removes a grand total of one FP on DCA.

Pull Request checklist

All query authors

• A change note is added if necessary. See the documentation in this repository.
• All new queries have appropriate .qhelp. See the documentation in this repository.
• QL tests are added if necessary. See Testing custom queries in the GitHub documentation.
• New and changed queries have correct query metadata. See the documentation in this repository.

Internal query authors only

• Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
• Changes are validated at scale (internal access required).
• Adding a new query? Consider also adding the query to autofix.

[jketema]

I assume this is an FP, because it neither occurs on the line with the literal, not occurs in any of the arguments?

[calumgrant]

Yes, so this is one of the FPs we saw on DCA that the current query or fixed query fails to catch. The problem is that the syntax error occurs on line 16, whereas the literal and function call are on line 15, and there is no obvious way to associate the two.

There is no ErrorExpr in the function call, and the extent of the function call is only line 15. So right now, I can't think of a good way to detect this case.

It looks like the frontend's syntax error recovery means dropping all of the expressions until the next ), which is pretty reasonable.

[jketema]

Needs a change note, otherwise, LGTM.

[jketema]

Please remove the commit that changes the date on the change note. This is going to cause a merge conflict with the ongoing 2.20.0 release, which deletes the file.