C++: Fix FPs in cpp/badly-bounded-write caused by extraction errors #18222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
DCA output looks good, showing the 8 FPs removed. |
jketema
reviewed
Dec 6, 2024
| destSize = max(getBufferSize(bw.getDest(), _)) and | ||
| bw.getExplicitLimit() > destSize // but it's larger than the destination | ||
| bw.getExplicitLimit() > destSize and // but it's larger than the destination | ||
| not bw.getDest().getUnderlyingType().stripType() instanceof ErroneousType // destSize may be incorrect |
Contributor
There was a problem hiding this comment.
Yes, I believe stripType takes care of that already.
Contributor
Author
|
I'll do another DCA once everything else looks good. (The custom suite ran just the query that changed.) |
jketema
reviewed
Dec 6, 2024
Co-authored-by: Jeroen Ketema <[email protected]>
Contributor
|
This is now basically waiting for a more complete DCA run. |
jketema
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).