C++: Remove pointer/pointee conflation from parameter nodes #18531
+21
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
force-pushed
the
remove-conflation-from-out-nodes
branch
from
5bc3caf to
f678d66
Compare
MathiasVP
force-pushed
the
remove-conflation-from-out-nodes
branch
from
f678d66 to
8de7d4e
Compare
MathiasVP
added
the
depends on internal PR
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (6)
- cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll: Language not supported
- cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll: Language not supported
- cpp/ql/test/experimental/query-tests/Security/CWE/CWE-409/DecompressionBombs/DecompressionBombs.expected: Language not supported
- cpp/ql/test/library-tests/dataflow/dataflow-tests/dataflow-consistency.expected: Language not supported
- cpp/ql/test/library-tests/dataflow/dataflow-tests/test.cpp: Language not supported
- cpp/ql/test/query-tests/Security/CWE/CWE-119/semmle/tests/UnboundedWrite.expected: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
node.hasAddressOperandAndIndirectionIndex(op, indirectionIndex)can hold for multiple(op, indirectionIndex)pairs for a givennode(because a singleDataFlow::Nodecan represent multipleOperands with different indirections) it's pretty much always a bug to only consideroporindirectionIndexin isolation. I thought we had fixed all problems like this as of #13425, but apparently this one was still lurking.Luckily, the fix is simple 🎉