Closed
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
coadaflorin
reviewed
Mar 7, 2025
| * Deleted the deprecated :code:`LValue` and :code:`RValue` classes, use :code:`VarWrite` and :code:`VarRead` respectively instead. | ||
| * Deleted a lot of deprecated classes ending in :code:`*Access`, use the corresponding :code:`*Call` classes instead. | ||
| * Deleted a lot of deprecated predicates ending in :code:`*Access`, use the corresponding :code:`*Call` predicates instead. | ||
| * Deleted a lot of deprecated classes ending in ``*Access``, use the corresponding ``*Call`` classes instead. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Deleted a lot of deprecated classes ending in ``*Access``, use the corresponding ``*Call`` classes instead. | |
| * Deleted a lot of deprecated classes ending in :code:``*Access``, use the corresponding :code:``*Call`` classes instead. |
Contributor
There was a problem hiding this comment.
I think we still want the code blocks, so it looks nice. But we also need to escape those pesky * so I think this is the final form...
coadaflorin
reviewed
Mar 7, 2025
| * Deleted a lot of deprecated classes ending in :code:`*Access`, use the corresponding :code:`*Call` classes instead. | ||
| * Deleted a lot of deprecated predicates ending in :code:`*Access`, use the corresponding :code:`*Call` predicates instead. | ||
| * Deleted a lot of deprecated classes ending in ``*Access``, use the corresponding ``*Call`` classes instead. | ||
| * Deleted a lot of deprecated predicates ending in ``*Access``, use the corresponding ``*Call`` predicates instead. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Deleted a lot of deprecated predicates ending in ``*Access``, use the corresponding ``*Call`` predicates instead. | |
| * Deleted a lot of deprecated predicates ending in :code:``*Access``, use the corresponding :code:``*Call`` predicates instead. |
coadaflorin
reviewed
Mar 7, 2025
| * Deleted the deprecated :code:`Collection` class from :code:`ActiveResource.qll`, use :code:`CollectionSource` instead. | ||
| * Deleted the deprecated :code:`ServiceInstantiation` and :code:`ClientInstantiation` classes from :code:`Twirp.qll`. | ||
| * Deleted a lot of deprecated dataflow modules from :code:`*Query.qll` files. | ||
| * Deleted a lot of deprecated dataflow modules from ``*Query.qll`` files. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Deleted a lot of deprecated dataflow modules from ``*Query.qll`` files. | |
| * Deleted a lot of deprecated dataflow modules from :code:``*Query.qll`` files. |
coadaflorin
reviewed
Mar 7, 2025
| Golang | ||
| """""" | ||
|
|
||
| * Go 1.24 is now supported. This includes the new language feature of generic type aliases. |
Contributor
There was a problem hiding this comment.
We do want this to be in, but I think we can add this again when we re-generate the changelog so we can drop it for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #18944
need to fix some excaping