actions: add some missing permissions#19494
Merged
yoff merged 1 commit intogithub:mainfrom May 23, 2025
Merged
Conversation
yoff
reviewed
May 19, 2025
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
Thanks for your contribution and for providing both tests and a nice change note! I have one question about one of the actions, otherwise this looks great.
| - ["actions/attest-build-provenance", "attestations: write"] | ||
| - ["actions/deploy-pages", "pages: write"] | ||
| - ["actions/deploy-pages", "id-token: write"] | ||
| - ["actions/delete-package-versions", "packages: write"] |
Contributor
There was a problem hiding this comment.
From here I see "The token needs the delete packages and read packages scope." Does that mean that we should also add packages: read?
Contributor
Author
There was a problem hiding this comment.
Thanks for checking! I was under the impression write includes read so packages: write will be enough?
Contributor
There was a problem hiding this comment.
Ah, I can see here that you are right.
I am sorry I missed your comment. In the future, feel free to re-request a review (the circle-arrow in the reviewers section), then I will get pinged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #19357 - I noticed a couple of other actions which did not have permissions set
Tagging @yoff who may be interested in this