Skip to content

Rust: Update DotDotCheck to use getCanonicalPath #19804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2025
Merged

Rust: Update DotDotCheck to use getCanonicalPath #19804

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd6975f
Rust: Update DotDotCheck from getResolvedPath -> getCanonicalPath.
geoffw0 Jun 17, 2025
cfe2559
Merge branch 'main' into dotdot
geoffw0 Jul 24, 2025
7f65980
Rust: Fix the canonical path.
geoffw0 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rust/ql/lib/codeql/rust/security/TaintedPathExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ module SanitizerGuard {
*/
private class DotDotCheck extends SanitizerGuard::Range, CfgNodes::MethodCallExprCfgNode {
DotDotCheck() {
this.getAstNode().(Resolvable).getResolvedPath() = "<str>::contains" and
this.getAstNode().(CallExprBase).getStaticTarget().(Addressable).getCanonicalPath() =
["<alloc::string::String>::contains", "<core::str>::contains"] and
this.getArgument(0).getAstNode().(LiteralExpr).getTextValue() =
["\"..\"", "\"../\"", "\"..\\\""]
}
Expand Down