Rust: Update legacy MaD models 3

[geoffw0]

Update even more legacy MaD models to the new model format (continues from #19942 and should be independent of that).

[geoffw0]

There's currently a large number of test changes caused by this PR (highlighted by CI). I think it would be prudent to get the first two PRs merged before attempting to address this. --- no longer true.

[aibaars]

At a glance the test changes are due to re-ordering of lines, so that looks fine to me.

[geoffw0]

The lost sources in the frameworks/rusqlite test I've added to the issue logging regressions. The rest of the CI failures were just location and model changes. I think this is good to merge now.

[aibaars]

Are you sure the problem is a missing canonical path, or is the problem that getStaticTarget fails (due to type inferencer problem)?

[aibaars]

Just checked the canonical path exists, the problem is the type inferencer, most likely the closure argument.

[geoffw0]

Yep you're right, the getStaticTarget fails (and thus getStaticTarget().(Addressable).getCanonicalPath() fails too) so it's likely a type inference problem.

[aibaars]

Yeah that's why I use a concat in my test predicate:

predicate test(MethodCallExpr e, Function target, string path) {
  target = e.getStaticTarget() and
  path = concat(target.getCanonicalPath())
}

• no result means getStaticTarget() failed
• empty string means: a target was found, but getCanonicalPath() failed

[aibaars]

Looks mostly fine, the rusqlite test failures can be fixed though.

[aibaars]

Just insert the following and record the failure cause as a type inferencer test.

        let row: &rusqlite::Row<'_> = row;

[geoffw0]

I'll do this tomorrow morning and check everything looks OK then.

[aibaars]

Just insert the following and record the failure cause as a type inferencer test.

        let row: &rusqlite::Row<'_> = row;