Skip to content

Go: Fix compilation of DataFlowImplConsistency.qll #20053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jul 15, 2025

As pointed out in #19890, this file didn't compile.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Jul 15, 2025
@Copilot Copilot AI review requested due to automatic review settings July 15, 2025 12:52
@owen-mc owen-mc requested a review from a team as a code owner July 15, 2025 12:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compilation error in the DataFlowImplConsistency.qll file by adding a module alias to resolve naming conflicts. The fix addresses the issue reported in GitHub issue #19890 where the file failed to compile due to ambiguous references to GoDataFlow.

  • Adds an alias Impl for the DataFlowImplSpecific import to disambiguate references
  • Updates references to GoDataFlow to use the qualified name Impl::GoDataFlow

@github-actions github-actions bot added the Go label Jul 15, 2025
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure how much weight my review carries 😄

@owen-mc owen-mc merged commit 53e1939 into github:main Jul 17, 2025
18 checks passed
@owen-mc owen-mc deleted the go/fix-dataflowconsistency branch July 17, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants