Skip to content

C++: Diff-informed queries: phase 3 (non-trivial locations) #20073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

d10c
Copy link
Contributor

@d10c d10c commented Jul 17, 2025

This PR enables diff-informed mode on queries that select a location other than dataflow source or sink. This entails adding a non-trivial location override that returns the locations that are actually selected.

Prior work includes PRs like #19663, #19759, and #19817. This PR uses the same patch script as those PRs to find candidate queries to convert to diff-enabled. This is the final step in mass-enabling diff-informed queries on all the languages.

Commit-by-commit reviewing is recommended.

  • I have split the commits that add/modify tests from the ones that enable/disable diff-informed queries.
  • If the commit modifies a .qll file, in the commit message I've included links to the queries that depend on that .qll for easier reviewing.
  • Feel free to delegate parts of the review to others who may be more specialized in certain languages.

Potentially tricky cases:

d10c added 26 commits July 17, 2025 10:54
@github-actions github-actions bot added the C++ label Jul 17, 2025
@d10c d10c added the no-change-note-required This PR does not need a change note label Jul 17, 2025
@d10c d10c requested a review from michaelnebel July 17, 2025 13:40
@d10c d10c marked this pull request as ready for review July 17, 2025 13:40
@Copilot Copilot AI review requested due to automatic review settings July 17, 2025 13:40
@d10c d10c requested a review from a team as a code owner July 17, 2025 13:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables diff-informed mode on C++ security queries that select locations other than dataflow source or sink. The changes add location override predicates to allow these queries to work with diff-informed analysis, which is part of the final phase of mass-enabling diff-informed queries across all languages.

Key changes include:

  • Addition of observeDiffInformedIncrementalMode() predicates to enable diff-informed mode
  • Implementation of getASelectedSourceLocation() and getASelectedSinkLocation() predicates to specify relevant locations
  • Creation of test files for CWE-020 (External API) and CWE-313 (Cleartext SQLite Database) queries

Reviewed Changes

Copilot reviewed 41 out of 43 changed files in this pull request and generated no comments.

File Description
Multiple security query files Added diff-informed mode configuration with location override predicates
CleartextSqliteDatabase test files Added comprehensive test case with SQLite security vulnerabilities
ExternalAPI test files Added test infrastructure for external API queries
ExternalAPIsSpecific.qll files Disabled diff-informed mode for library code used by multiple queries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant